Github user abh commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/920#discussion_r90795038
--- Diff: iocore/net/OCSPStapling.cc ---
@@ -382,9 +382,11 @@ ocsp_update()
if (cinf->resp_derlen == 0 || cinf->is_expire || cinf->expire_time
< current_time) {
ink_mutex_release(&cinf->stapling_mutex);
if (stapling_refresh_response(cinf, &resp)) {
- Note("Success to refresh OCSP response for 1 certificate.");
+ Debug("ssl_ocsp", "Successful OCSP refresh response for 1
certificate");
+ SSL_INCREMENT_DYN_STAT(ssl_ocsp_refreshed_cert_stat);
} else {
- Note("Fail to refresh OCSP response for 1 certificate.");
+ Debug("ssl_ocsp", "Failed to refresh OCSP for 1 certificate");
--- End diff --
It'd be nice to keep the failures in the non-debug logs, I think. Nicer if
it included some information about the cert that couldn't be updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
