[
https://issues.apache.org/jira/browse/TS-4268?focusedWorklogId=32903&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-32903
]
ASF GitHub Bot logged work on TS-4268:
--------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/16 02:14
Start Date: 05/Dec/16 02:14
Worklog Time Spent: 10m
Work Description: Github user abh commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/920#discussion_r90795038
--- Diff: iocore/net/OCSPStapling.cc ---
@@ -382,9 +382,11 @@ ocsp_update()
if (cinf->resp_derlen == 0 || cinf->is_expire || cinf->expire_time
< current_time) {
ink_mutex_release(&cinf->stapling_mutex);
if (stapling_refresh_response(cinf, &resp)) {
- Note("Success to refresh OCSP response for 1 certificate.");
+ Debug("ssl_ocsp", "Successful OCSP refresh response for 1
certificate");
+ SSL_INCREMENT_DYN_STAT(ssl_ocsp_refreshed_cert_stat);
} else {
- Note("Fail to refresh OCSP response for 1 certificate.");
+ Debug("ssl_ocsp", "Failed to refresh OCSP for 1 certificate");
--- End diff --
It'd be nice to keep the failures in the non-debug logs, I think. Nicer if
it included some information about the cert that couldn't be updated.
Issue Time Tracking
-------------------
Worklog Id: (was: 32903)
Time Spent: 1h (was: 50m)
> Verbose OCSP notes in syslog
> ----------------------------
>
> Key: TS-4268
> URL: https://issues.apache.org/jira/browse/TS-4268
> Project: Traffic Server
> Issue Type: Improvement
> Components: Logging
> Reporter: Leif Hedstrom
> Assignee: Randall Meyer
> Fix For: 7.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We're seeing a fair amount of this in our syslog:
> {code}
> traffic_server[18384]: {0x2aaabbb02700} NOTE: <OCSPStapling.cc:385
> (ocsp_update)> Success to refresh OCSP response for 1 certificate.
> {code}
> This comes from
> {code}
> iocore/net/OCSPStapling.cc:385: Note("Success to refresh OCSP
> response for 1 certificate.");
> {code}
> I'm not able to see a metric for this, [~jacksontj] suggests we should have
> one for that instead of spewing this Note's. And I'm +1 on that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
