[
https://issues.apache.org/jira/browse/TS-5085?focusedWorklogId=33192&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33192
]
ASF GitHub Bot logged work on TS-5085:
--------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/16 21:22
Start Date: 07/Dec/16 21:22
Worklog Time Spent: 10m
Work Description: GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1254
TS-5085 `posix_fadvise` is incorrectly used in traffic_logcat
`traffic_logcat` was not using `posix_fadvise` correctly. This
patch corrects the original poor usage as well as adds some more
`posix_fadvise` calls that should help with performance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-5085
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1254.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1254
----
commit 9e81f07421a10c3028fcbdefd6aaca79065b4446
Author: Daniel Xu <[email protected]>
Date: 2016-12-07T21:20:05Z
TS-5085 `posix_fadvise` is incorrectly used in traffic_logcat
`traffic_logcat` was not using `posix_fadvise` correctly. This
patch corrects the original poor usage as well as adds some more
`posix_fadvise` calls that should help with performance.
----
Issue Time Tracking
-------------------
Worklog Id: (was: 33192)
Time Spent: 10m
Remaining Estimate: 0h
> `posix_fadvise` is incorrectly used in traffic_logcat
> -----------------------------------------------------
>
> Key: TS-5085
> URL: https://issues.apache.org/jira/browse/TS-5085
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: Daniel Xu
> Assignee: Daniel Xu
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{traffic_logcat}} is currently using {{posix_fadvise}} the exact opposite
> way it should be used. It's currently telling the kernel it doesn't need
> anything in this file and then immediately proceeds to read everything in the
> file anyways.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
