[
https://issues.apache.org/jira/browse/TS-5085?focusedWorklogId=33200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33200
]
ASF GitHub Bot logged work on TS-5085:
--------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/16 23:51
Start Date: 07/Dec/16 23:51
Worklog Time Spent: 10m
Work Description: Github user danobi commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1254#discussion_r91414850
--- Diff: proxy/logcat.cc ---
@@ -300,6 +307,9 @@ main(int /* argc ATS_UNUSED */, const char *argv[])
}
}
}
+ // Now that we're done reading a potentially large log file, we can
tell the kernel that it's OK to evict
+ // the associated log file pages from cache
+ posix_fadvise(in_fd, 0, 0, POSIX_FADV_DONTNEED);
--- End diff --
Oops, I forgot to wrap this call in `#if`'s. Will fix soon.
Issue Time Tracking
-------------------
Worklog Id: (was: 33200)
Time Spent: 0.5h (was: 20m)
> `posix_fadvise` is incorrectly used in traffic_logcat
> -----------------------------------------------------
>
> Key: TS-5085
> URL: https://issues.apache.org/jira/browse/TS-5085
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: Daniel Xu
> Assignee: Daniel Xu
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{traffic_logcat}} is currently using {{posix_fadvise}} the exact opposite
> way it should be used. It's currently telling the kernel it doesn't need
> anything in this file and then immediately proceeds to read everything in the
> file anyways.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
