Github user jablko commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1398#discussion_r99871965
--- Diff: cmd/traffic_top/Makefile.am ---
@@ -17,13 +17,13 @@
# We only build traffic_top if libcurses and libcurl are available.
if BUILD_TRAFFIC_TOP
-
AM_CPPFLAGS = \
$(iocore_include_dirs) \
-I$(abs_top_srcdir)/lib \
-I$(abs_top_srcdir)/mgmt/api/include \
@CURL_CFLAGS@ \
@CURSES_CFLAGS@
+endif
--- End diff --
I assume this change will cause build failure if curses isn't installed,
because bin_PROGRAMS = traffic_top etc. are outside the BUILD_TRAFFIC_TOP
conditional? If so, I think you can drop this file from the PR (git checkout
master cmd/traffic_top/Makefile.am).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
