Github user jablko commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1398#discussion_r99866474
--- Diff: configure.ac ---
@@ -220,6 +220,22 @@ AC_ARG_ENABLE([fast-sdk],
AC_MSG_RESULT([$enable_fast_sdk])
TS_ARG_ENABLE_VAR([use], [fast-sdk])
+# Curl support for traffic_top
+AC_MSG_CHECKING([whether to enable CURL])
+AC_ARG_ENABLE([curl],
+ [AS_HELP_STRING([--disable-curl],[turn off CURL support for
traffic_top])],
+ [],
+ [enable_curl=yes]
+)
+AC_MSG_RESULT([$enable_curl])
+
+if test "x${enable_curl}" = "xyes"; then
+AX_LIB_CURL([7.19], [has_curl=1],[has_curl=0])
+AM_CONDITIONAL([HAS_CURL], [test "x$has_curl" = "xyes"])
+else
+AM_CONDITIONAL([HAS_CURL], [false])
+fi
--- End diff --
I haven't yet tested this with/without libcurl installed, but I assume that
here, you need to use AC_DEFINE vs. AM_CONDITIONAL, because HAS_CURL is a
preprocessor macro? As it stands, I expect HAS_CURL will be undefined, whether
libcurl is installed/enabled or not. If so, I'd replace lines 233-236 with the
following line:
```M4Sugar
AX_LIB_CURL([7.19], [AC_DEFINE([HAS_CURL], [1], [Define if libcurl >=
7.19.])])
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
