GitHub user jablko opened a pull request:
https://github.com/apache/trafficserver/pull/1435
Prefer setting AM_CPPFLAGS vs. CPPFLAGS, etc.
Autoconf and Automake discourage setting some Makefile variables [1].
They encourage setting their AM_ variants instead.
[1] https://www.gnu.org/software/automake/manual/automake#User-Variables
This change covers most but not all of these cases -- in a few cases, 1) we
set CPPFLAGS because AC_LINK_IFELSE (etc.) doesn't know about AM_CPPFLAGS, and
2) macros update these variables internally. We can easily work around both
cases with some creative save/restoring (or alternatively, by updating the
macro definition), but I think the benefit isn't worth the complexity, and
there are only a few of these cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jablko/trafficserver am_flags
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1435.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1435
----
commit c817d11a1bc62ea09a7c14a79728f15449152100
Author: Jack Bates <[email protected]>
Date: 2017-02-08T20:40:51Z
Prefer setting AM_CPPFLAGS vs. CPPFLAGS, etc.
Autoconf and Automake discourage setting some Makefile variables [1].
They encourage setting their AM_ variants instead.
[1] https://www.gnu.org/software/automake/manual/automake#User-Variables
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
