Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1451#discussion_r101526314
  
    --- Diff: iocore/eventsystem/P_IOBuffer.h ---
    @@ -694,6 +695,7 @@ TS_INLINE char &IOBufferReader::operator[](int64_t i)
       }
     
       ink_release_assert(!"out of range");
    +  return default_ret[0];
    --- End diff --
    
    The real problem is ICC doesn't realize the assert never returns.
    
    Although, I don't understand why `static char zwoop = '0';` `return zwoop;` 
wouldn't work, rather than messing about with an array.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to