Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1451#discussion_r101558553
--- Diff: lib/ts/signals.cc ---
@@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler)
sigact = (void *)oact.sa_sigaction;
}
- if (sigact != handler) {
+ if (sigact != (void *)handler) {
--- End diff --
I did look / try not using void *, but it turns out the sigaction is not
the same type as the handler. So some casting would be needed.
And yeh, I'll change to amc style cast, only because you are the best, and
currently sitting in the #1 spot on the ranking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
