Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1477#discussion_r102279727
  
    --- Diff: proxy/InkAPI.cc ---
    @@ -7772,395 +7772,372 @@ TSSkipRemappingSet(TSHttpTxn txnp, int flag)
     }
     
     // Little helper function to find the struct member
    -static void *
    -_conf_to_memberp(TSOverridableConfigKey conf, OverridableHttpConfigParams 
*overridableHttpConfig, OverridableDataType *typep)
    +#define GET_OVERIDE(var)                \
    +  do {                                  \
    +    type = overridable_typeof(var);     \
    +    return static_cast<void *>(&(var)); \
    +  } while (0)
    +
    +template <typename T>
    +OverridableDataType
    +overridable_typeof(T &t)
    +{
    +  static_assert(ts_always_false<T>::value, "Invalid overridable type or 
member");
    --- End diff --
    
    No, can't do that, because that fails always on compile time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to