Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103611267
--- Diff: plugins/esi/combo_handler.cc ---
@@ -187,6 +207,94 @@ InterceptData::~InterceptData()
}
}
+void
+CacheControlHeader::update(TSMBuffer bufp, TSMLoc hdr_loc)
+{
+ vector<string> values;
--- End diff --
Perhaps convolute the search logic. In that case there would be a
`std::array<char const*, 3>` initialized to the 3 values of interest. Each item
in the loop at 221 would have an inner loop like that starting at 241. Then
there's no need to allocate a vector as a temporary, and the comparisons can be
done using `strcasecmp` to avoid the copy as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
