Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103965565
--- Diff: plugins/esi/combo_handler.cc ---
@@ -136,6 +138,24 @@ struct InterceptData {
~InterceptData();
};
+/*
+ * This class is responsible for keeping track of and processing the
various
+ * Cache-Control values between all the requested documents
+ */
+struct CacheControlHeader {
+ // Update the object with a document's Cache-Control header
+ void update(TSMBuffer bufp, TSMLoc hdr_loc);
+
+ // Return the Cache-Control for the combined document
+ string generate() const;
+
+ // Cache-Control values we're keeping track of
+ int _max_age = 315360000; // max value (10 years)
--- End diff --
Actually I believe the max value should be 1 year. According to [RFC
2616](https://www.ietf.org/rfc/rfc2616.txt),
```
To mark a response as "never expires," an origin server sends an
Expires date approximately one year from the time the response is
sent. HTTP/1.1 servers SHOULD NOT send Expires dates more than one
year in the future.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
