Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1446#discussion_r104750433
--- Diff: iocore/net/SSLNetVConnection.cc ---
@@ -1438,17 +1438,22 @@ bool
SSLNetVConnection::callHooks(TSEvent eventId)
{
// Only dealing with the SNI/CERT hook so far.
- ink_assert(eventId == TS_EVENT_SSL_CERT);
+ ink_assert(eventId == TS_EVENT_SSL_CERT || eventId ==
TS_EVENT_SSL_SERVERNAME);
Debug("ssl", "callHooks sslHandshakeHookState=%d",
this->sslHandshakeHookState);
// First time through, set the type of the hook that is currently being
invoked
- if (HANDSHAKE_HOOKS_PRE == sslHandshakeHookState) {
+ if ((this->sslHandshakeHookState == HANDSHAKE_HOOKS_PRE ||
this->sslHandshakeHookState == HANDSHAKE_HOOKS_DONE) &&
--- End diff --
For SSL_CTX_set_early_cb, perhaps as we move to openssl1.1 we should make
that change.
For the sslHandshakeHookState == DONE, probably not needed since we reset
the hook state to PRE at the end of the servername chain. There is a flaw with
this PR, and I am in the process of putting up another one. I'll probably
leave the DONE check for now. I'm in the process of writing a test suite for
this logic since it has bitten me multiple times. I'll do the tidy up once the
test suite is there to check me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
