[
https://issues.apache.org/jira/browse/TRAFODION-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424364#comment-16424364
]
ASF GitHub Bot commented on TRAFODION-3009:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1504#discussion_r178909282
--- Diff: core/sql/exp/ExpError.cpp ---
@@ -135,6 +135,20 @@ ComDiagsArea *ExRaiseSqlError(CollHeap* heap,
ComDiagsArea** diagsArea,
intParam1, intParam2, intParam3,
stringParam1, stringParam2, stringParam3);
}
+
+ComDiagsArea *ExRaiseSqlError(CollHeap* heap, ComDiagsArea** diagsArea,
--- End diff --
In many other places we use ComDiagsArea *&diags, so I'm wondering why we
are using ** here.
> Streamline error handling in Executor utility commands
> ------------------------------------------------------
>
> Key: TRAFODION-3009
> URL: https://issues.apache.org/jira/browse/TRAFODION-3009
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: -exe, sql-exe
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
> Priority: Major
>
> Executor utility commands are the commands that issue sql statements during
> its execution to complete its task. These operators are derived from
> ExExeUtilTcb operator in Trafodion. These commands assume ComDiagsArea is
> allocated in advance. This is not in accordance with the design as outlined in
> [https://cwiki.apache.org/confluence/display/TRAFODION/SQL+Diagnostics+Architecture+and+Design]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
