[ 
https://issues.apache.org/jira/browse/TRAFODION-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424514#comment-16424514
 ] 

ASF GitHub Bot commented on TRAFODION-3009:
-------------------------------------------

Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1504#discussion_r178944088
  
    --- Diff: core/sql/executor/ExExeUtilExplain.cpp ---
    @@ -237,8 +237,7 @@ short ExExeUtilDisplayExplainTcb::work()
              executeImmediate("control session 'EXPLAIN' 'ON';");
            if (retcode < 0)
              {
    -           cliInterface()->retrieveSQLDiagnostics(getDiagsArea());
    -
    +                
setDiagsArea(cliInterface()->allocAndRetrieveSQLDiagnostics(getDiagsArea()));
    --- End diff --
    
    Yes. I could do that for ExExeUtilTcb portion of the code.  


> Streamline error handling in Executor utility commands
> ------------------------------------------------------
>
>                 Key: TRAFODION-3009
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3009
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: -exe, sql-exe
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Selvaganesan Govindarajan
>            Priority: Major
>
> Executor utility commands are the commands that issue sql statements during 
> its execution to complete its task. These operators are  derived from 
> ExExeUtilTcb operator in Trafodion.  These commands assume ComDiagsArea is 
> allocated in advance. This is not in accordance with the design as outlined in
> [https://cwiki.apache.org/confluence/display/TRAFODION/SQL+Diagnostics+Architecture+and+Design]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to