[ 
https://issues.apache.org/jira/browse/TRAFODION-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426152#comment-16426152
 ] 

ASF GitHub Bot commented on TRAFODION-3009:
-------------------------------------------

Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1504#discussion_r179279239
  
    --- Diff: core/sql/executor/ExExeUtilGet.cpp ---
    @@ -1818,8 +1813,9 @@ short ExExeUtilGetMetadataInfoTcb::work()
            {
                    if (!CmpCommon::context()->isAuthorizationEnabled())
                    {
    -                  ComDiagsArea * diags = getDiagsArea();
    -                  *diags << DgSqlCode(-CAT_AUTHORIZATION_NOT_ENABLED);
    +                  ComDiagsArea * diagsArea = getDiagsArea();
    +                  ExRaiseSqlError(getHeap(), &diagsArea, 
-CAT_AUTHORIZATION_NOT_ENABLED);
    +                  setDiagsArea(diagsArea);
    --- End diff --
    
    I misunderstood your comment. I thought that you wanted to make a function. 
Yes. I am changing it to pass in diagsArea_ directly, so that we can do this in 
a single statement. diagsArea_ already has protected mode access.


> Streamline error handling in Executor utility commands
> ------------------------------------------------------
>
>                 Key: TRAFODION-3009
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3009
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: -exe, sql-exe
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Selvaganesan Govindarajan
>            Priority: Major
>
> Executor utility commands are the commands that issue sql statements during 
> its execution to complete its task. These operators are  derived from 
> ExExeUtilTcb operator in Trafodion.  These commands assume ComDiagsArea is 
> allocated in advance. This is not in accordance with the design as outlined in
> [https://cwiki.apache.org/confluence/display/TRAFODION/SQL+Diagnostics+Architecture+and+Design]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to