[
https://issues.apache.org/jira/browse/TRAFODION-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515393#comment-16515393
]
ASF GitHub Bot commented on TRAFODION-3110:
-------------------------------------------
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1612#discussion_r195974505
--- Diff: core/sql/executor/ExExeUtilGet.cpp ---
@@ -7733,26 +7733,12 @@ else
return rc;
//EOD of LOB data file
-
- hdfsFS fs =
currContext->getHdfsServerConnection((char*)getLItdb().getHdfsServer(),getLItdb().getHdfsPort());
- if (fs == NULL)
- return LOB_DATA_FILE_OPEN_ERROR;
-
-
snprintf(lobDataFilePath, LOBINFO_MAX_FILE_LEN, "%s/%s", lobLocation,
lobDataFile);
- hdfsFile fdData = hdfsOpenFile(fs, lobDataFilePath,O_RDONLY,0,0,0);
- if (!fdData)
- {
- hdfsCloseFile(fs,fdData);
- fdData = NULL;
- return LOB_DATA_FILE_OPEN_ERROR;
- }
- hdfsFileInfo *fInfo = hdfsGetPathInfo(fs, lobDataFilePath);
- if (fInfo)
- lobEOD = fInfo->mSize;
- else
- lobEOD = 0;
-
+ HDFS_Client_RetCode hdfsClientRetcode;
--- End diff --
The toggle is missing here ? We shoudl preserve the old interface here.
> Refactor LOB access to use the new implementation of HdfsClient
> ---------------------------------------------------------------
>
> Key: TRAFODION-3110
> URL: https://issues.apache.org/jira/browse/TRAFODION-3110
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-exe
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
> Priority: Major
>
> By making LOB to use the new implementation of HdfsClient, the use of libHdfs
> is avoided in yet another feature. This also simplifies the hdfs access
> related code in this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
