[ 
https://issues.apache.org/jira/browse/TRAFODION-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522638#comment-16522638
 ] 

ASF GitHub Bot commented on TRAFODION-3110:
-------------------------------------------

Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1612#discussion_r197893780
  
    --- Diff: core/sql/executor/HdfsClient_JNI.h ---
    @@ -182,13 +186,16 @@ class HdfsClient : public JavaObjectInterface
       HDFS_Client_RetCode    init();
       HDFS_Client_RetCode    hdfsCreate(const char* path, NABoolean overwrite, 
NABoolean compress);
       HDFS_Client_RetCode    hdfsOpen(const char* path, NABoolean compress);
    -  Int32                  hdfsWrite(const char* data, Int64 size, 
HDFS_Client_RetCode &hdfsClientRetcode);
    -  Int32                  hdfsRead(const char* data, Int64 size, 
HDFS_Client_RetCode &hdfsClientRetcode);
    +  Int64                  hdfsSize(HDFS_Client_RetCode &hdfsClientRetcode);
    +  Int32                  hdfsWrite(const char* data, Int64 size, 
HDFS_Client_RetCode &hdfsClientRetcode, int maxChunkSize = 0);
    --- End diff --
    
    maxChunkSize is passed in as Int64 from caller. Here it's declared as int.


> Refactor LOB access to use the new implementation of HdfsClient
> ---------------------------------------------------------------
>
>                 Key: TRAFODION-3110
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3110
>             Project: Apache Trafodion
>          Issue Type: Sub-task
>          Components: sql-exe
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Selvaganesan Govindarajan
>            Priority: Major
>
> By making LOB to use the new implementation of HdfsClient, the use of libHdfs 
> is avoided in yet another feature. This also simplifies the hdfs access 
> related code in this feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to