[
https://issues.apache.org/jira/browse/TRAFODION-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522821#comment-16522821
]
ASF GitHub Bot commented on TRAFODION-3110:
-------------------------------------------
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1612#discussion_r197942792
--- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java ---
@@ -359,36 +392,54 @@ int hdfsWrite(byte[] buff) throws IOException
logger_.debug("HDFSClient.hdfsWrite() - output stream created"
);
}
outStream_.write(buff);
+ if (outStream_ instanceof FSDataOutputStream)
+ ((FSDataOutputStream)outStream_).hsync();
if (logger_.isDebugEnabled())
logger_.debug("HDFSClient.hdfsWrite() - bytes written " +
buff.length);
return buff.length;
}
--- End diff --
Ok. I see one placce where hdfsWrite is also called. But int hat case I
suppose we don't need to the EOD. Eitherway, what is the difference between
hdfsWrite and hdfsWriteImmediate ? Also while hdfsWriteImmediate is coccuring ,
can another threadprocess write to the same hdfsfile or is the entire
hdfsWriteImmediate done under a lock ?
> Refactor LOB access to use the new implementation of HdfsClient
> ---------------------------------------------------------------
>
> Key: TRAFODION-3110
> URL: https://issues.apache.org/jira/browse/TRAFODION-3110
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-exe
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
> Priority: Major
>
> By making LOB to use the new implementation of HdfsClient, the use of libHdfs
> is avoided in yet another feature. This also simplifies the hdfs access
> related code in this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
