[
https://issues.apache.org/jira/browse/TRAFODION-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525597#comment-16525597
]
ASF GitHub Bot commented on TRAFODION-3110:
-------------------------------------------
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1612#discussion_r198635546
--- Diff: core/sql/executor/HdfsClient_JNI.h ---
@@ -171,7 +175,7 @@ class HdfsClient : public JavaObjectInterface
~HdfsClient();
static HdfsClient *newInstance(NAHeap *heap, ExHdfsScanStats *hdfsStats,
HDFS_Client_RetCode &retCode, int hdfsIoByteArraySizeInKB = 0);
static HdfsClient *getInstance();
- static void deleteInstance();
+ static void deleteInstance(HdfsClient *hdfsClient);
--- End diff --
Attempted to make it as non-static method. But it involves the deletion of
itself. Hence I decided to keep it as static for better readability.
void HdfsClient::deleteInstance(HdfsClient *hdfsClient)
{
hdfsClient->hdfsClose();
NADELETE(hdfsClient, HdfsClient, hdfsClient->getHeap());
}
> Refactor LOB access to use the new implementation of HdfsClient
> ---------------------------------------------------------------
>
> Key: TRAFODION-3110
> URL: https://issues.apache.org/jira/browse/TRAFODION-3110
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-exe
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
> Priority: Major
>
> By making LOB to use the new implementation of HdfsClient, the use of libHdfs
> is avoided in yet another feature. This also simplifies the hdfs access
> related code in this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
