[ 
https://issues.apache.org/jira/browse/TRAFODION-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525638#comment-16525638
 ] 

ASF GitHub Bot commented on TRAFODION-3110:
-------------------------------------------

Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1612#discussion_r198646970
  
    --- Diff: core/sql/cli/SessionDefaults.cpp ---
    @@ -108,6 +108,7 @@ static const SessionDefaults::SessionDefaultMap 
sessionDefaultMap[] =
       SDEntry(SessionDefaults::SCHEMA,                   SCHEMA,               
      SessionDefaults::SDT_ASCII,          TRUE,    TRUE,  FALSE, FALSE),
       SDEntry(SessionDefaults::STATISTICS_VIEW_TYPE,     STATISTICS_VIEW_TYPE, 
      SessionDefaults::SDT_ASCII,          FALSE,   FALSE, TRUE,  TRUE),
       SDEntry(SessionDefaults::SUSPEND_LOGGING,          SUSPEND_LOGGING,      
      SessionDefaults::SDT_BOOLEAN,        FALSE,   FALSE, TRUE,  FALSE),
    +  SDEntry(SessionDefaults::USE_LIBHDFS,              USE_LIBHDFS,          
      SessionDefaults::SDT_BOOLEAN,        TRUE,    TRUE,  FALSE, FALSE),
    --- End diff --
    
    It's fine if the DDL interfaces use the new implementation since we just 
create or drop. Since you took care of the 2 utility operations UPDATE and 
EXTRACT, looks like we are covered all the main functionality with this toggle 
now. Looks good +1 .  Can merge as soon as the test passes. 


> Refactor LOB access to use the new implementation of HdfsClient
> ---------------------------------------------------------------
>
>                 Key: TRAFODION-3110
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3110
>             Project: Apache Trafodion
>          Issue Type: Sub-task
>          Components: sql-exe
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Selvaganesan Govindarajan
>            Priority: Major
>
> By making LOB to use the new implementation of HdfsClient, the use of libHdfs 
> is avoided in yet another feature. This also simplifies the hdfs access 
> related code in this feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to