[
https://issues.apache.org/jira/browse/TRAFODION-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634603#comment-16634603
]
ASF GitHub Bot commented on TRAFODION-3216:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1721#discussion_r221723371
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp ---
@@ -9246,26 +9280,44 @@ short CmpSeabaseDDL::executeSeabaseDDL(DDLExpr *
ddlExpr, ExprNode * ddlNode,
// create seabase library
StmtDDLCreateLibrary * createLibraryParseNode =
ddlNode->castToStmtDDLNode()->castToStmtDDLCreateLibrary();
-
- createSeabaseLibrary(createLibraryParseNode, currCatName,
+ if( (CmpCommon::getDefault(USE_LIB_BLOB_STORE) == DF_OFF))
+ createSeabaseLibrary(createLibraryParseNode, currCatName,
currSchName);
+ else
+ {
+
+ createSeabaseLibrary2(createLibraryParseNode, currCatName,
+ currSchName);
+
+
+ }
}
else if (ddlNode->getOperatorType() == DDL_DROP_LIBRARY)
{
// drop seabase library
StmtDDLDropLibrary * dropLibraryParseNode =
ddlNode->castToStmtDDLNode()->castToStmtDDLDropLibrary();
-
- dropSeabaseLibrary(dropLibraryParseNode, currCatName,
currSchName);
+ if( (CmpCommon::getDefault(USE_LIB_BLOB_STORE) == DF_OFF))
+ dropSeabaseLibrary(dropLibraryParseNode, currCatName,
currSchName);
+ else
+ {
+ dropSeabaseLibrary2(dropLibraryParseNode, currCatName,
currSchName);
+ }
}
else if (ddlNode->getOperatorType() == DDL_ALTER_LIBRARY)
{
// create seabase library
StmtDDLAlterLibrary * alterLibraryParseNode =
ddlNode->castToStmtDDLNode()->castToStmtDDLAlterLibrary();
-
- alterSeabaseLibrary(alterLibraryParseNode, currCatName,
- currSchName);
+ if( (CmpCommon::getDefault(USE_LIB_BLOB_STORE) == DF_OFF))
+ alterSeabaseLibrary(alterLibraryParseNode, currCatName,
--- End diff --
Same as above, shouldn't the flavor of the library determine what method to
call? I assume we can't change a library from the old method to a BLOB and vice
versa. To do that, it needs to be dropped and recreated with a different CQD
setting.
> UDR libraries need to be stored in metadata table as a blob
> -----------------------------------------------------------
>
> Key: TRAFODION-3216
> URL: https://issues.apache.org/jira/browse/TRAFODION-3216
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-general
> Affects Versions: 2.4
> Reporter: Sandhya Sundaresan
> Assignee: Sandhya Sundaresan
> Priority: Major
> Fix For: 2.4
>
> Attachments: Support for LOB storage in metadata for UDR
> libraries.docx
>
>
> This is one of many infrastructure changes for SPJs that was planned.
> * {color:#0070c0}Store UDR libraries in BLOBs {color}
> * {color:#0070c0}Add BLOB column to library metadata table{color}
> * {color:#0070c0}Change CREATE LIBRARY command to store library in
> BLOB{color}
> * {color:#0070c0}Change library file names to include the timestamp (so
> updating a library changes the name){color}
> * {color:#0070c0}Add a cache for libraries (a new directory,
> $TRAF_HOME/udr/public/lib){color}
> * {color:#0070c0}Change UDR code to read library from the metadata table
> when not in cache{color}
> * {color:#0070c0}Upgrade support{color}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
