[ https://issues.apache.org/jira/browse/TRAFODION-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634602#comment-16634602 ]
ASF GitHub Bot commented on TRAFODION-3216: ------------------------------------------- Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221726951 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -563,32 +795,332 @@ void CmpSeabaseDDL::dropSeabaseLibrary(StmtDDLDropLibrary * dropLibraryNode, processReturn(); return; } - -void CmpSeabaseDDL::alterSeabaseLibrary(StmtDDLAlterLibrary *alterLibraryNode, - NAString &currCatName, - NAString &currSchName) +void CmpSeabaseDDL::dropSeabaseLibrary(StmtDDLDropLibrary * dropLibraryNode, --- End diff -- It might be nicer to combine these two methods, dropSeabaseLibrary2 and dropSeabaseLibrary, into one, given how much code they have in common. Same for the create and alter methods. > UDR libraries need to be stored in metadata table as a blob > ----------------------------------------------------------- > > Key: TRAFODION-3216 > URL: https://issues.apache.org/jira/browse/TRAFODION-3216 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-general > Affects Versions: 2.4 > Reporter: Sandhya Sundaresan > Assignee: Sandhya Sundaresan > Priority: Major > Fix For: 2.4 > > Attachments: Support for LOB storage in metadata for UDR > libraries.docx > > > This is one of many infrastructure changes for SPJs that was planned. > * {color:#0070c0}Store UDR libraries in BLOBs {color} > * {color:#0070c0}Add BLOB column to library metadata table{color} > * {color:#0070c0}Change CREATE LIBRARY command to store library in > BLOB{color} > * {color:#0070c0}Change library file names to include the timestamp (so > updating a library changes the name){color} > * {color:#0070c0}Add a cache for libraries (a new directory, > $TRAF_HOME/udr/public/lib){color} > * {color:#0070c0}Change UDR code to read library from the metadata table > when not in cache{color} > * {color:#0070c0}Upgrade support{color} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)