[
https://issues.apache.org/jira/browse/TRAFODION-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649570#comment-16649570
]
ASF GitHub Bot commented on TRAFODION-3216:
-------------------------------------------
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1721#discussion_r225014810
--- Diff: core/sql/executor/ExUdr.cpp ---
@@ -792,9 +796,57 @@ Int32 ExUdrTcb::fixup()
this, udrServer_->getUdrControlConnection());
}
}
-
+
+ NAString cachedLibName, cachedLibPath;
+ if ((myTdb().getLibraryRedefTime() != -1) &&
(myTdb().getLibraryRedefTime() != 0))
+ {
+ // Cache library locally.
+ NAString dummyUser;
+ NAString libOrJarName;
+
+ if (myTdb().getLanguage() == COM_LANGUAGE_JAVA)
+ libOrJarName = myTdb().getPathName();
+ else
+ libOrJarName = myTdb().getContainerName();
+ if(ComGenerateUdrCachedLibName(libOrJarName.data(),
+ myTdb().getLibraryRedefTime(),
+ myTdb().getLibrarySchName(),
+ dummyUser,
+ cachedLibName, cachedLibPath))
+ {
+ NAString cachedFullName = cachedLibPath+"/"+cachedLibName;
+ *getOrCreateStmtDiags() << DgSqlCode(-4316)
+ << DgString0(( char
*)cachedFullName.data());;
--- End diff --
As briefly mentioned this earlier. One thing that has been discussed is to
have better error messages that would make debugging customer problems easier.
In this case, instead of just saying unable to extract library, you could
mention that is was because we were unable to create the directory structure
and include details returned from mkdir.
> UDR libraries need to be stored in metadata table as a blob
> -----------------------------------------------------------
>
> Key: TRAFODION-3216
> URL: https://issues.apache.org/jira/browse/TRAFODION-3216
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-general
> Affects Versions: 2.4
> Reporter: Sandhya Sundaresan
> Assignee: Sandhya Sundaresan
> Priority: Major
> Fix For: 2.4
>
> Attachments: Support for LOB storage in metadata for UDR
> libraries.docx
>
>
> This is one of many infrastructure changes for SPJs that was planned.
> * {color:#0070c0}Store UDR libraries in BLOBs {color}
> * {color:#0070c0}Add BLOB column to library metadata table{color}
> * {color:#0070c0}Change CREATE LIBRARY command to store library in
> BLOB{color}
> * {color:#0070c0}Change library file names to include the timestamp (so
> updating a library changes the name){color}
> * {color:#0070c0}Add a cache for libraries (a new directory,
> $TRAF_HOME/udr/public/lib){color}
> * {color:#0070c0}Change UDR code to read library from the metadata table
> when not in cache{color}
> * {color:#0070c0}Upgrade support{color}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)