[
https://issues.apache.org/jira/browse/TRAFODION-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649565#comment-16649565
]
ASF GitHub Bot commented on TRAFODION-3216:
-------------------------------------------
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1721#discussion_r225014825
--- Diff: core/sql/generator/Generator.cpp ---
@@ -2352,6 +2352,14 @@ TrafDesc *Generator::createVirtualRoutineDesc(
strcpy(routine_desc->routineDesc()->signature, routineInfo->signature);
routine_desc->routineDesc()->librarySqlName = new GENHEAP(space)
char[strlen(routineInfo->library_sqlname)+1];
strcpy(routine_desc->routineDesc()->librarySqlName,
routineInfo->library_sqlname);
+ routine_desc->routineDesc()->libRedefTime = routineInfo->lib_redef_time;
+ routine_desc->routineDesc()->libBlobHandle =
routineInfo->lib_blob_handle;
+
+ routine_desc->routineDesc()->libVersion = routineInfo->library_version;
+ routine_desc->routineDesc()->libObjUID = routineInfo->lib_obj_uid;
+ //routine_desc->routineDesc()->libSchName = new GENHEAP(space)
char[strlen(routineInfo->lib_sch_name)+1];
+ //strcpy(routine_desc->routineDesc()->libSchName
,routineInfo->lib_sch_name);
+ routine_desc->routineDesc()->libSchName = routineInfo->lib_sch_name;
--- End diff --
Remove comments? Do you need a deep copy for lib_sch_name?
> UDR libraries need to be stored in metadata table as a blob
> -----------------------------------------------------------
>
> Key: TRAFODION-3216
> URL: https://issues.apache.org/jira/browse/TRAFODION-3216
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-general
> Affects Versions: 2.4
> Reporter: Sandhya Sundaresan
> Assignee: Sandhya Sundaresan
> Priority: Major
> Fix For: 2.4
>
> Attachments: Support for LOB storage in metadata for UDR
> libraries.docx
>
>
> This is one of many infrastructure changes for SPJs that was planned.
> * {color:#0070c0}Store UDR libraries in BLOBs {color}
> * {color:#0070c0}Add BLOB column to library metadata table{color}
> * {color:#0070c0}Change CREATE LIBRARY command to store library in
> BLOB{color}
> * {color:#0070c0}Change library file names to include the timestamp (so
> updating a library changes the name){color}
> * {color:#0070c0}Add a cache for libraries (a new directory,
> $TRAF_HOME/udr/public/lib){color}
> * {color:#0070c0}Change UDR code to read library from the metadata table
> when not in cache{color}
> * {color:#0070c0}Upgrade support{color}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
