[ 
https://issues.apache.org/jira/browse/TRAFODION-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649559#comment-16649559
 ] 

ASF GitHub Bot commented on TRAFODION-3216:
-------------------------------------------

Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1721#discussion_r225014835
  
    --- Diff: core/sql/optimizer/UdfDllInteraction.cpp ---
    @@ -136,6 +137,64 @@ NABoolean 
TMUDFDllInteraction::describeParamsAndMaxOutputs(
           bindWA->setErrStatus();
           return FALSE;
         }
    +  NAString externalPath, container;
    +  
    +  // If the library is old style (no blob) and it's not a predfined udf 
with no entry in metadata
    +  // i.e redeftime of library is not -1
    +  if(  routine->getLibRedefTime() !=-1)
    +    {
    +      // Cache library locally. 
    +      NAString dummyUser;
    +      NAString libOrJarName;
    +      NAString cachedLibName,cachedLibPath;  
    +      if (routine->getLanguage() == COM_LANGUAGE_JAVA)
    +        libOrJarName = routine->getExternalPath();
    +      else
    +        libOrJarName = routine->getContainerName();
    +      if(ComGenerateUdrCachedLibName(libOrJarName.data(),
    --- End diff --
    
    This  code looks a lot like ExUdr.cpp.  Is it similar enough to create a 
subprocedure that both can call?


> UDR libraries need to be stored in metadata table as a blob
> -----------------------------------------------------------
>
>                 Key: TRAFODION-3216
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3216
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: sql-general
>    Affects Versions: 2.4
>            Reporter: Sandhya Sundaresan
>            Assignee: Sandhya Sundaresan
>            Priority: Major
>             Fix For: 2.4
>
>         Attachments: Support for LOB storage in metadata for UDR 
> libraries.docx
>
>
> This is one of many  infrastructure changes for SPJs that was planned. 
>  * {color:#0070c0}Store UDR libraries in BLOBs   {color}
>  * {color:#0070c0}Add BLOB column to library metadata table{color}
>  * {color:#0070c0}Change CREATE LIBRARY command to store library in 
> BLOB{color}
>  * {color:#0070c0}Change library file names to include the timestamp (so 
> updating a library changes the name){color}
>  * {color:#0070c0}Add a cache for libraries (a new directory, 
> $TRAF_HOME/udr/public/lib){color}
>  * {color:#0070c0}Change UDR code to read library from the metadata table 
> when not in cache{color}
>  * {color:#0070c0}Upgrade support{color}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to