[
https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=321281&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321281
]
ASF GitHub Bot logged work on TRAFODION-3328:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/19 14:06
Start Date: 01/Oct/19 14:06
Worklog Time Spent: 10m
Work Description: selvaganesang commented on pull request #1858:
[TRAFODION-3328] Code cleanup in NADefaults
URL: https://github.com/apache/trafodion/pull/1858
Avoid reading VERSIONS and DEFAULTS table after it is done once in a process.
This required following cleanup
1. cqd MODE_SEABASE is removed.
2. Removed the support to read CQD from a file.
3. NADefaults constructor now reads the defaults table once and
saves off the relevant information such as currentDefaults, currentTokens,
provenances and currentFloats to be reused by the other NADefaults
objects.
4. T2 driver doesn't use the defaultContext to compile any query. Hence, it
is not
possible to use the heap from CmpContext to save off the defaults value.
The code has been changed the heap from CliGlobals to save the current
defaults.
5. Fixed code to use static literals as it is from the defaultsDefaults to
avoid invalid memory in the saved defaults
6. Changes to optimize initialization of currentTokens_ in NADefaults
7. CQD * RESET RESET
CQD * RESET
Now resets to the defaults when CQD * RESET RESET was issued.
8. Also optimized initCurrentsFromDefaultsTable further.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 321281)
Remaining Estimate: 0h
Time Spent: 10m
> Code cleanup in NADefaults
> --------------------------
>
> Key: TRAFODION-3328
> URL: https://issues.apache.org/jira/browse/TRAFODION-3328
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-cmp
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> With embedded compiler, there is a need to have many cmpContexts to compile
> the query because the compile code is not re-entrant.
> With many cmpContext, there is a need to ensure the elements of cmpContext
> are managed in an optimal way. This Jira is created to track all the
> improvements that can be done in this area.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
