[
https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322148
]
ASF GitHub Bot logged work on TRAFODION-3328:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/19 18:50
Start Date: 02/Oct/19 18:50
Worklog Time Spent: 10m
Work Description: DaveBirdsall commented on pull request #1858:
[TRAFODION-3328] Code cleanup in NADefaults
URL: https://github.com/apache/trafodion/pull/1858#discussion_r330712806
##########
File path: core/sql/sqlcomp/nadefaults.cpp
##########
@@ -3629,11 +3622,12 @@ void
NADefaults::initCurrentDefaultsWithDefaultDefaults()
}
// End: Temporary workaround for SQL build regressions to pass
- // Cache all the default keywords up front,
// leaving other non-keyword token to be cached on demand.
Review comment:
Should this comment line (line 3625 in the new file) be deleted also? It
doesn't make sense by itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 322148)
Time Spent: 1h 20m (was: 1h 10m)
> Code cleanup in NADefaults
> --------------------------
>
> Key: TRAFODION-3328
> URL: https://issues.apache.org/jira/browse/TRAFODION-3328
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-cmp
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> With embedded compiler, there is a need to have many cmpContexts to compile
> the query because the compile code is not re-entrant.
> With many cmpContext, there is a need to ensure the elements of cmpContext
> are managed in an optimal way. This Jira is created to track all the
> improvements that can be done in this area.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
