[
https://issues.apache.org/jira/browse/TRAFODION-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700350#comment-14700350
]
ASF GitHub Bot commented on TRAFODION-1457:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/60#discussion_r37244951
--- Diff: core/sql/optimizer/BindItemExpr.cpp ---
@@ -10298,23 +10298,23 @@ NABoolean ZZZBinderFunction::isPadWithSpace
(ExprValueId& padExpr, CharInfo::Cha
if ((padExpr->castToItemExpr()->getOperatorType() == ITM_CONSTANT) &&
(!((ConstValue *)padExpr->castToItemExpr())->getText().isNull()))
{
- NAWString padString(
- ((ConstValue *)padExpr->castToItemExpr())->getConstWStr());
+ NAString padString(
+ ((ConstValue *)padExpr->castToItemExpr())->getConstStr(FALSE));
Int32 i = 0;
NABoolean foundSingleQuote = FALSE;
- for (const NAWchar *s = padString.data(); *s; s++)
+ for (const char *s = padString.data(); *s; s++)
{
- i++; // 0x0027 is the single quote character '
- if ((!foundSingleQuote)&&(*s != 0x0027)) // loop through
+ i++; // 0x27 is the single quote character '
+ if ((!foundSingleQuote)&&(*s != 0x27)) // loop through
continue; // the prefix _UCS2 or _ISO88591
else if ((!foundSingleQuote))
{
foundSingleQuote = TRUE; // found the leading single quote.
continue;
}
- if ((i == (padString.length())) && (*s == 0x0027)) // trailing
single quote
+ if ((i == (padString.length())) && (*s == 0x27)) // trailing single
quote
continue;
- if (*s != 0x0020) // 0x0020 is the single space character ' '
+ if (*s != 0x20) // 0x20 is the single space character ' '
--- End diff --
Again, slightly more portable to code *s != ' '
> Fix a collection of issues related to decoding HBase region keys and updating
> the TEXT metadata table
> -----------------------------------------------------------------------------------------------------
>
> Key: TRAFODION-1457
> URL: https://issues.apache.org/jira/browse/TRAFODION-1457
> Project: Apache Trafodion
> Issue Type: Bug
> Environment: any
> Reporter: Hans Zeller
> Assignee: Hans Zeller
>
> The code I wrote a while ago for handling incomplete HBase region keys needs
> some more improvement, which caused me to clean up a few related areas. One
> of them is generation of min/max values for key building. Also, I would like
> to change the methods we use to read and update the "_MD_".TEXT table.
> Changing quotes to double quotes should happen inside this method, not last
> because it should only happen on the individual chunks to be inserted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
