[
https://issues.apache.org/jira/browse/TRAFODION-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700367#comment-14700367
]
ASF GitHub Bot commented on TRAFODION-1457:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/60#discussion_r37246073
--- Diff: core/sql/optimizer/NATable.cpp ---
@@ -1472,58 +1478,161 @@ static ItemExpr *
getRangePartitionBoundaryValuesFromEncodedKeys(
// value. Note that the buffer has a prefix of some bytes
with actual key
// values, followed by bytes that are zeroed out.
+ // the number of bytes actually provided in the key (not
filled in)
+ int numBytesInProvidedVal = encodedKeyLen-valOffset;
+
+ if (nullHdrSize && numBytesInProvidedVal <= 0)
--- End diff --
The condition numBytesInProvidedVal <= 0 should always be true by
definition of columnIsPartiallyProvided. Doesn't hurt anything though, just
makes reading more complicated.
> Fix a collection of issues related to decoding HBase region keys and updating
> the TEXT metadata table
> -----------------------------------------------------------------------------------------------------
>
> Key: TRAFODION-1457
> URL: https://issues.apache.org/jira/browse/TRAFODION-1457
> Project: Apache Trafodion
> Issue Type: Bug
> Environment: any
> Reporter: Hans Zeller
> Assignee: Hans Zeller
>
> The code I wrote a while ago for handling incomplete HBase region keys needs
> some more improvement, which caused me to clean up a few related areas. One
> of them is generation of min/max values for key building. Also, I would like
> to change the methods we use to read and update the "_MD_".TEXT table.
> Changing quotes to double quotes should happen inside this method, not last
> because it should only happen on the individual chunks to be inserted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
