[
https://issues.apache.org/jira/browse/TRAFODION-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355435#comment-15355435
]
ASF GitHub Bot commented on TRAFODION-1676:
-------------------------------------------
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/564#discussion_r68969297
--- Diff: core/sql/cli/Statement.cpp ---
@@ -2102,6 +2102,30 @@ Statement *
Statement::getCurrentOfCursorStatement(char * cursorName)
}
+//////////////////////////////////////////////////////////////////
+////
+//// A helper function to show buffer in HEX
+////
+//// ///////////////////////////////////////////////////////////////
+
+static char *stringToHex(char * out, Int32 outLen, char * in, Int32 inLen)
--- End diff --
Could this function please be declared in some place like exp/ExpError.h
(with an implementation in ExpError.cpp)? I see this function implemented twice
in this PR and something similar in a previous PR. I think this is not
advisable according to our coding guidelines.
> support better runtime error message when a SQL function meet fital error
> -------------------------------------------------------------------------
>
> Key: TRAFODION-1676
> URL: https://issues.apache.org/jira/browse/TRAFODION-1676
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-exe
> Reporter: liu ming
> Assignee: liu ming
> Priority: Minor
>
> A sql contains some SQL function, for example UPPER(), when the input data of
> UPPER() contains invalid data, UPPER() will fail. In this case, the whole
> query abort, and the error message cannot tell which row has invalid data, so
> it is very hard to fix the problem.
> It will be good to have row id or the real value of the error row in the
> error message to help trouble shooting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
