[ 
https://issues.apache.org/jira/browse/TRAFODION-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355454#comment-15355454
 ] 

ASF GitHub Bot commented on TRAFODION-1676:
-------------------------------------------

Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/564#discussion_r68972142
  
    --- Diff: core/sql/exp/exp_datetime.cpp ---
    @@ -1908,6 +1932,11 @@ scanField(char *&src,
           // An unknown character was encountered in the string.
           //
           ExRaiseSqlError(heap, diagsArea, EXE_CONVERT_STRING_ERROR);
    +      char hexstr[256];
    +      memset(hexstr, 0 , sizeof(hexstr) );
    --- End diff --
    
     Please consider removing this line.The memset is also present in 
stringToHex.


> support better runtime error message when a SQL function meet fital error
> -------------------------------------------------------------------------
>
>                 Key: TRAFODION-1676
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-1676
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: sql-exe
>            Reporter: liu ming
>            Assignee: liu ming
>            Priority: Minor
>
> A sql contains some SQL function, for example UPPER(), when the input data of 
> UPPER() contains invalid data, UPPER() will fail. In this case, the whole 
> query abort, and the error message cannot tell which row has invalid data, so 
> it is very hard to fix the problem.
> It will be good to have row id or the real value of the error row in the 
> error message to help trouble shooting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to