[ 
https://issues.apache.org/jira/browse/TRAFODION-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552377#comment-15552377
 ] 

ASF GitHub Bot commented on TRAFODION-2263:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/746#discussion_r82224469
  
    --- Diff: core/sql/comexe/CmpMessage.h ---
    @@ -419,8 +415,7 @@ class CmpCompileInfo
     
       char * sqltext_;    // 00-03
       Lng32 sqlTextLen_;   // 04-07
    -  RecompLateNameInfoList * rlnil_;  // 08-11
    -  Lng32 rlnilLen_;  // 12-15
    +  Lng32 unused_;       // 12-15
    --- End diff --
    
    Should this be an Int64? and should the comment say, // 08-15? (Though I 
don't think it matters anymore since we don't do static SQL.)


> Move Similarity check for hive tables to master executor root operator
> ----------------------------------------------------------------------
>
>                 Key: TRAFODION-2263
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2263
>             Project: Apache Trafodion
>          Issue Type: Improvement
>            Reporter: Anoop Sharma
>            Assignee: Anoop Sharma
>            Priority: Minor
>
> Query plans for hive tables include location of data directories/files
> and the plan depends on it.
> If data changes in a hive file/dir after a query has been compiled and
> before it is executed, then that change is detected at runtime by
> comparing compile time and runtime dir timestamps.
> A mismatch causes that query to recompile using AQR and a new
> plan is generated with latest dir location.
> This detection is currently being done at leaf operators (scan, insert) when
> that operator is executed.
> This jira is to move that check (called Similarity Check) to the root 
> operator before starting query execution. That way plan consistency
> checks will be done before running the query and will not depend
> on the actual operator being executed. It will also result in checks not
> being done at various processes and operators like an ESP process.
> All checks will be done at one place in master executor and code will not
> be spread across multiple operators as it is now.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to