[
https://issues.apache.org/jira/browse/TRAFODION-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552374#comment-15552374
]
ASF GitHub Bot commented on TRAFODION-2263:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/746#discussion_r82225212
--- Diff: core/sql/comexe/LateBindInfo.cpp ---
@@ -1319,37 +1049,102 @@ Int16 AnsiOrNskName::quoteNSKExtName()
return 0;
}
-void ResolvedNameListPre1800::translateFromNewVersion(ResolvedNameList
*newrnl)
+///////////////////////////////////////////////////////////////////
+// class TrafSimilarityTableInfo
+///////////////////////////////////////////////////////////////////
+TrafSimilarityTableInfo::TrafSimilarityTableInfo(char * tableName,
+ NABoolean isHive,
+ char * hdfsRootDir,
+ Int64 modTS, Int32
numPartnLevels,
+ Queue * hdfsDirsToCheck,
+ char * hdfsHostName,
+ Int32 hdfsPort)
+ : NAVersionedObject(-1),
+ tableName_(tableName),
+ hdfsRootDir_(hdfsRootDir),
+ modTS_(modTS), numPartnLevels_(numPartnLevels),
+ hdfsDirsToCheck_(hdfsDirsToCheck),
+ hdfsHostName_(hdfsHostName), hdfsPort_(hdfsPort)
--- End diff --
Looks like we need an initializer to set flags_ = 0. If we don't do this,
and isHive is false, the HIVE flag will be uninitialized (and therefore random).
> Move Similarity check for hive tables to master executor root operator
> ----------------------------------------------------------------------
>
> Key: TRAFODION-2263
> URL: https://issues.apache.org/jira/browse/TRAFODION-2263
> Project: Apache Trafodion
> Issue Type: Improvement
> Reporter: Anoop Sharma
> Assignee: Anoop Sharma
> Priority: Minor
>
> Query plans for hive tables include location of data directories/files
> and the plan depends on it.
> If data changes in a hive file/dir after a query has been compiled and
> before it is executed, then that change is detected at runtime by
> comparing compile time and runtime dir timestamps.
> A mismatch causes that query to recompile using AQR and a new
> plan is generated with latest dir location.
> This detection is currently being done at leaf operators (scan, insert) when
> that operator is executed.
> This jira is to move that check (called Similarity Check) to the root
> operator before starting query execution. That way plan consistency
> checks will be done before running the query and will not depend
> on the actual operator being executed. It will also result in checks not
> being done at various processes and operators like an ESP process.
> All checks will be done at one place in master executor and code will not
> be spread across multiple operators as it is now.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
