[ 
https://issues.apache.org/jira/browse/TRAFODION-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609962#comment-15609962
 ] 

ASF GitHub Bot commented on TRAFODION-2127:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/772#discussion_r85231158
  
    --- Diff: core/sql/generator/GenRelScan.cpp ---
    @@ -1119,7 +1124,8 @@ short FileScan::codeGenForHive(Generator * generator)
       if (expirationTimestamp > 0)
         expirationTimestamp += 1000000 *
           (Int64) CmpCommon::getDefaultLong(HIVE_METADATA_REFRESH_INTERVAL);
    -  generator->setPlanExpirationTimestamp(expirationTimestamp);
    +  if (!getCommonSubExpr())
    +    generator->setPlanExpirationTimestamp(expirationTimestamp);
    --- End diff --
    
    Could you explain what a plan expiration timestamp is? (not in the code 
necessarily... but in a reply comment maybe?)


> enhance Trafodion implementation of WITH clause
> -----------------------------------------------
>
>                 Key: TRAFODION-2127
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2127
>             Project: Apache Trafodion
>          Issue Type: Improvement
>            Reporter: liu ming
>            Assignee: Hans Zeller
>
> TRAFODION-1673 described some details about how to support WITH clause in 
> Trafodion.
> As initial implementation, we use a simple pure-parser method.
> That way, Trafodion can support WITH clause functionally, but not good from 
> performance point of view,
> also need to enhance the parser to be more strict in syntax.
> This JIRA is a follow up JIRA, to track following effort to support Trafodion 
> WITH clause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to