[ 
https://issues.apache.org/jira/browse/TRAFODION-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609959#comment-15609959
 ] 

ASF GitHub Bot commented on TRAFODION-2127:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/772#discussion_r85232063
  
    --- Diff: core/sql/optimizer/ItemExpr.cpp ---
    @@ -10441,6 +10441,20 @@ void ConstValue::changeStringConstant(const 
NAString* strval)
        *text_ = *strval;
     }
     
    +NABoolean ConstValue::isAFalseConstant() const
    +{
    +  NABoolean result = FALSE;
    +
    +  if (type_->getTypeQualifier() == NA_BOOLEAN_TYPE && !isNull())
    +    {
    +      CMPASSERT(storageSize_ == sizeof(Int32));
    +      if (*(reinterpret_cast<Int32 *>(value_)) == 0)
    +        result = TRUE; // that means the constant is FALSE!!
    --- End diff --
    
    :-)


> enhance Trafodion implementation of WITH clause
> -----------------------------------------------
>
>                 Key: TRAFODION-2127
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2127
>             Project: Apache Trafodion
>          Issue Type: Improvement
>            Reporter: liu ming
>            Assignee: Hans Zeller
>
> TRAFODION-1673 described some details about how to support WITH clause in 
> Trafodion.
> As initial implementation, we use a simple pure-parser method.
> That way, Trafodion can support WITH clause functionally, but not good from 
> performance point of view,
> also need to enhance the parser to be more strict in syntax.
> This JIRA is a follow up JIRA, to track following effort to support Trafodion 
> WITH clause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to