[
https://issues.apache.org/jira/browse/TRAFODION-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652753#comment-15652753
]
ASF GitHub Bot commented on TRAFODION-1562:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/826#discussion_r87305909
--- Diff: core/sql/optimizer/BindRelExpr.cpp ---
@@ -10298,10 +10331,17 @@ RelExpr *Insert::bindNode(BindWA *bindWA)
}
if (isUpsertThatNeedsMerge(isAlignedRowFormat, omittedDefaultCols,
omittedCurrentDefaultClassCols)) {
- boundExpr = xformUpsertToMerge(bindWA);
- return boundExpr;
+ if (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_OFF)
+ {
+ boundExpr = xformUpsertToMerge(bindWA);
+ return boundExpr;
+ }
+ else if( CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON)
+ boundExpr = xformUpsertToEfficientTree(bindWA);
+
--- End diff --
This does nothing if TRAF_UPSERT_TO_EFF_TREE is set to something other than
ON or OFF, is that ok? In this case we could produce incorrect results as far
as I understand.
> Changes in query tree when the upsert command is transformed into merge
> -----------------------------------------------------------------------
>
> Key: TRAFODION-1562
> URL: https://issues.apache.org/jira/browse/TRAFODION-1562
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-cmp
> Reporter: Selvaganesan Govindarajan
> Assignee: Sandhya Sundaresan
> Attachments: BatchUpsertTransformation.pdf
>
>
> to improve the performance as explained in the main JIRA
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
