[
https://issues.apache.org/jira/browse/TRAFODION-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652749#comment-15652749
]
ASF GitHub Bot commented on TRAFODION-1562:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/826#discussion_r87315691
--- Diff: core/sql/optimizer/BindWA.h ---
@@ -685,6 +685,8 @@ class BindScope : public NABasicObject
// --------------------------------------------------------------------
RelExpr *&getSequenceNode() { return sequenceNode_; };
+ ValueIdMap &getNcToOldMap() { return ncToOldMap_;}
--- End diff --
For new code, could you make a "get" and a "set" method instead of
returning a writable reference. I know a lot of old code still has this style
of method.
> Changes in query tree when the upsert command is transformed into merge
> -----------------------------------------------------------------------
>
> Key: TRAFODION-1562
> URL: https://issues.apache.org/jira/browse/TRAFODION-1562
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-cmp
> Reporter: Selvaganesan Govindarajan
> Assignee: Sandhya Sundaresan
> Attachments: BatchUpsertTransformation.pdf
>
>
> to improve the performance as explained in the main JIRA
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
