[ 
https://issues.apache.org/jira/browse/TRAFODION-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834640#comment-15834640
 ] 

ASF GitHub Bot commented on TRAFODION-2420:
-------------------------------------------

Github user nonstop-qfchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/918#discussion_r97324910
  
    --- Diff: core/sql/executor/ExStats.h ---
    @@ -3791,9 +3791,9 @@ NA_EIDPROC
       short  &cmpPriority() {return cmpPriority_;}
       short  &dp2Priority() {return dp2Priority_;}
       short  &fixupPriority() {return fixupPriority_;}
    -  inline void setNumSqlProcs(short i) {numSqlProcs_ = i; }
    +  void  incNumEspsInUse() { numOfTotalEspsUsed_++; }
       inline void setNumCpus(short i) {numCpus_ = i; }
    -  inline short getNumSqlProcs() { return numSqlProcs_; }
    +  inline short getNumSqlProcs() { return numOfTotalEspsUsed_+1; }
    --- End diff --
    
    Should we +1 every time we call getNumSqlProcs()?


> RMS enhancements
> ----------------
>
>                 Key: TRAFODION-2420
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2420
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: sql-general
>    Affects Versions: 2.1-incubating
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Selvaganesan Govindarajan
>
> Improve RMS to provide the following features/capabilities:
> 1. Currently RMS can list queries that consumed cpu time between two time 
> points. However, the calls to storage engine like hbase, hdfs etc are 
> blocking and these blocked APIs will not allow the Trafodion SQL engine 
> scheduler to detect the cpu time spent during the time the call was blocked. 
> Introduce a feature called SE offender (storage engine offender) to list the 
> queries that are blocked in storage engine more than a certain duration.
> 2. Remove counters that are no longer updated or needed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to