[
https://issues.apache.org/jira/browse/TRAFODION-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834638#comment-15834638
]
ASF GitHub Bot commented on TRAFODION-2420:
-------------------------------------------
Github user nonstop-qfchen commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/918#discussion_r97323080
--- Diff: core/sql/executor/ExStats.cpp ---
@@ -2357,11 +2357,19 @@ Int64 ExHdfsScanStats::getNumVal(Int32 i) const
NABoolean ExHdfsScanStats::filterForSEstats(struct timespec currTimespec,
Lng32 filter)
{
- blockTime_ = timer_.filterForSEstats(currTimespec);
- if (blockTime_ >= filter)
- return TRUE;
+ Int64 sumIOTime;
+
+ if (filter > 0) {
+ blockTime_ = timer_.filterForSEstats(currTimespec);
+ if (blockTime_ >= filter)
+ return TRUE;
+ }
else
- return FALSE;
+ if (queryId_ != NULL && (sumIOTime = timer_.getTime()) > 0 &&
(sumIOTime = sumIOTime /(1000000LL)) >= -filter) {
--- End diff --
Could write as sumIOTime /= 1000000LL
> RMS enhancements
> ----------------
>
> Key: TRAFODION-2420
> URL: https://issues.apache.org/jira/browse/TRAFODION-2420
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-general
> Affects Versions: 2.1-incubating
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
>
> Improve RMS to provide the following features/capabilities:
> 1. Currently RMS can list queries that consumed cpu time between two time
> points. However, the calls to storage engine like hbase, hdfs etc are
> blocking and these blocked APIs will not allow the Trafodion SQL engine
> scheduler to detect the cpu time spent during the time the call was blocked.
> Introduce a feature called SE offender (storage engine offender) to list the
> queries that are blocked in storage engine more than a certain duration.
> 2. Remove counters that are no longer updated or needed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
