[
https://issues.apache.org/jira/browse/TRAFODION-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169459#comment-16169459
]
ASF GitHub Bot commented on TRAFODION-2731:
-------------------------------------------
GitHub user anoopsharma00 opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1236
TRAFODION-2731 CodeCleanup: Phase 2: Remove obsolete code
This phase handles the following:
-- removed files:
cli/rtdu.h, rtdu2.h, rtdu.cpp, rtdu.cpp
executor/dmeasql.h
executor/ExMeas.h, ExMeas.cpp
executor/tempfile.h, .cpp
executor/rcb.h
executor/stubs.cpp, stubs2.cpp
exp/srlversion.cpp
exp/exp_space.h
cli/VicKeyValuePair.h
cli/CliDll.cpp
cli/CliStubsStaticBuild.cpp
cli/globalsrlversion.cpp
cli/globalstubs.cpp
cli/sqlciSRLStubs.cpp
cli/test.cpp
cli/privsrlversion.cpp
common/SqlExpDllDefines.h
common/SqlExportDllDefines.h
sqlcat/enum.h
sqlcat/ReadTableDef.h, cpp
sqlcat/readRealArk.h, cpp
sqlshare/catapirequest.*
-- removed defines and code referencing them:
-- NA_STD_NAMESPACE
-- NA_NO_CMPCONTEXT
-- NA_CATMAN_SIM, NA_CATMAN_SIM_FS
-- common/purify.h
-- DONT_USE_MATH_H
-- NT_PORT
-- NA_MSVC
-- NA_NO_FRIENDS_WITH_TEMPLATE_REFS
-- NA_FLEXBUILD
-- NA_LINUX_SETENV
-- removed multiple obsolete sqlci features and syntax:
(report writer, MACL, Help, Simulators, Utils, MXCS mode, Help,
and few others).
-- removed following files in sqlci dir:
CSInterface.h
CharSetConstants.cpp
CharSetConstants.h
MsgCat.cpp
MsgCat.h
MxciEHCallBack.cpp
MxciEHCallBack.h
RWInterface.cpp
RWInterface.h
SqlciCSCmd.cpp
SqlciCSCmd.h
SqlciCSSimulator.cpp
SqlciHelp.cpp
SqlciRWCmd.cpp
SqlciRWCmd.h
SqlciRWSimulator.cpp
SqlciUsage.cpp
SqlciUtil.cpp
SqlciUtil.h
UtilInt.cpp
UtilInt.h
UtilMsg.cpp
UtilMsg.h
immudefs.cpp
immudefs.h
-- removed references to NT_PORT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anoopsharma00/incubator-trafodion
ansharma_t23cleanup_br
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1236
----
commit b952c0d5f96f773155467249631622a79e0ca68e
Author: Anoop Sharma <[email protected]>
Date: 2017-09-15T00:13:37Z
code cleanup, commit #1
commit 331fbd2aca3ac8938a8f6ead3c4b02687e562ee0
Author: Anoop Sharma <[email protected]>
Date: 2017-09-17T20:15:18Z
Merge remote branch 'origin/master' into ansharma_t23cleanup_br
commit 62b45310c224be5c2e83de0ca5afbd7ad283166b
Author: Anoop Sharma <[email protected]>
Date: 2017-09-17T23:09:11Z
TRAFODION-2731 CodeCleanup: Phase 2: Remove obsolete code
This phase handles the following:
-- removed files:
cli/rtdu.h, rtdu2.h, rtdu.cpp, rtdu.cpp
executor/dmeasql.h
executor/ExMeas.h, ExMeas.cpp
executor/tempfile.h, .cpp
executor/rcb.h
executor/stubs.cpp, stubs2.cpp
exp/srlversion.cpp
exp/exp_space.h
cli/VicKeyValuePair.h
cli/CliDll.cpp
cli/CliStubsStaticBuild.cpp
cli/globalsrlversion.cpp
cli/globalstubs.cpp
cli/sqlciSRLStubs.cpp
cli/test.cpp
cli/privsrlversion.cpp
common/SqlExpDllDefines.h
common/SqlExportDllDefines.h
sqlcat/enum.h
sqlcat/ReadTableDef.h, cpp
sqlcat/readRealArk.h, cpp
sqlshare/catapirequest.*
-- removed defines and code referencing them:
-- NA_STD_NAMESPACE
-- NA_NO_CMPCONTEXT
-- NA_CATMAN_SIM, NA_CATMAN_SIM_FS
-- common/purify.h
-- DONT_USE_MATH_H
-- NT_PORT
-- NA_MSVC
-- NA_NO_FRIENDS_WITH_TEMPLATE_REFS
-- NA_FLEXBUILD
-- removed multiple obsolete sqlci features and syntax:
(report writer, MACL, Help, Simulators, Utils, MXCS mode, Help,
and few others).
-- removed following files in sqlci dir:
CSInterface.h
CharSetConstants.cpp
CharSetConstants.h
MsgCat.cpp
MsgCat.h
MxciEHCallBack.cpp
MxciEHCallBack.h
RWInterface.cpp
RWInterface.h
SqlciCSCmd.cpp
SqlciCSCmd.h
SqlciCSSimulator.cpp
SqlciHelp.cpp
SqlciRWCmd.cpp
SqlciRWCmd.h
SqlciRWSimulator.cpp
SqlciUsage.cpp
SqlciUtil.cpp
SqlciUtil.h
UtilInt.cpp
UtilInt.h
UtilMsg.cpp
UtilMsg.h
immudefs.cpp
immudefs.h
----
> CodeCleanup: Remove obsolete, legacy and unused code
> ----------------------------------------------------
>
> Key: TRAFODION-2731
> URL: https://issues.apache.org/jira/browse/TRAFODION-2731
> Project: Apache Trafodion
> Issue Type: Improvement
> Reporter: Anoop Sharma
> Assignee: Anoop Sharma
> Priority: Minor
>
> There is code in trafodion branch that is leftover from previous product and
> is no longer used.
> It includes legacy features and code fragments, unneeded ifdef defines and
> obsolete files.
> Having all that old code makes it difficult to read, understand or make
> changes.
> This jira is filed to handle removal of obsolete code.
> It will be implemented in multiple phases.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
