[
https://issues.apache.org/jira/browse/TRAFODION-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202532#comment-16202532
]
ASF GitHub Bot commented on TRAFODION-2731:
-------------------------------------------
Github user anoopsharma00 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1262#discussion_r144393927
--- Diff: core/sql/common/Ipc.cpp ---
@@ -4580,44 +4565,21 @@ IpcServerClass::IpcServerClass(IpcEnvironment *env,
}
if (allocationMethod_ == IPC_ALLOC_DONT_CARE)
{
-#if (defined(NA_GUARDIAN_IPC))
- // NA_WINNT is set and NA_GUARDIAN_IPC is set
- // The standard method on NT is to create a Guardian process
- // in order to run in an NT only or simulated environment we can set
an environment
- // variable to override that mechanism.
- if (getenv("SQL_NO_NSK_LITE") == NULL)
- {
- allocationMethod_ = IPC_LAUNCH_GUARDIAN_PROCESS;
- }
- else
- {
- allocationMethod_ = IPC_LAUNCH_NT_PROCESS;
- time_t tp;
- time(&tp);
- nextPort_ = IPC_SQLESP_PORTNUMBER + tp % 10000; // arbitrary
- };
-
-#else // NA_GUARDIAN_IPC
-
- // NA_WINNT is set and NA_GUARDIAN_IPC is NOT set
- // The standard method on NT is to create an NT process
- // We use socket based communication but launch the process ourself
rather
- // than using INETD.
- // Eventually we will use nsk lite to create new processes and to
- // communicate via the message system.
- // in order to run in an NT only or simulated environment we can set
an environment
- // variable to override that mechanism.
- if (getenv("SQL_NO_NSK_LITE") == NULL)
- {allocationMethod_ = IPC_LAUNCH_GUARDIAN_PROCESS;
- }
- else
- {
- allocationMethod_ = IPC_LAUNCH_NT_PROCESS;
+ // NA_WINNT is set and NA_GUARDIAN_IPC is set
+ // The standard method on NT is to create a Guardian process
+ // in order to run in an NT only or simulated environment we can set
an environment
+ // variable to override that mechanism.
+ if (getenv("SQL_NO_NSK_LITE") == NULL)
--- End diff --
There are still some parts of code which use some of the NSK and NT
constructs.
They need to be looked at carefully before removing them.
But yes, obvious obsolete references like the one you pointed out, will be
removed
in a subsequent checkin.
> CodeCleanup: Remove obsolete, legacy and unused code
> ----------------------------------------------------
>
> Key: TRAFODION-2731
> URL: https://issues.apache.org/jira/browse/TRAFODION-2731
> Project: Apache Trafodion
> Issue Type: Improvement
> Reporter: Anoop Sharma
> Assignee: Anoop Sharma
> Priority: Minor
>
> There is code in trafodion branch that is leftover from previous product and
> is no longer used.
> It includes legacy features and code fragments, unneeded ifdef defines and
> obsolete files.
> Having all that old code makes it difficult to read, understand or make
> changes.
> This jira is filed to handle removal of obsolete code.
> It will be implemented in multiple phases.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
