kaijchen opened a new pull request, #38:
URL: https://github.com/apache/incubator-uniffle/pull/38
### What changes were proposed in this pull request?
1. Enable (previously experimental) spotbugs check in CI.
2. Set spotbugs to only check high priority bugs.
Because currently there are too many medium (default) priority bugs,
and many of them are difficult to fix.
3. Fix bugs reported by spotbugs.
### Why are the changes needed?
To improve code quality.
### Does this PR introduce _any_ user-facing change?
There is one notable change, see: a994cffed033158bfbd84d5b83e900892b739c18
We can revert it, if it's not desired.
### How was this patch tested?
1. `mvn test-compile spotbugs:check -Pspark3`
2. `mvn test-compile spotbugs:check -Pspark2`
3. `mvn test-compile spotbugs:check -Pmr`
Also by CI:
https://github.com/kaijchen/incubator-uniffle/actions/runs/2634089750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
