kaijchen commented on code in PR #38:
URL: https://github.com/apache/incubator-uniffle/pull/38#discussion_r916484606
##########
common/src/main/java/org/apache/uniffle/common/config/RssConf.java:
##########
@@ -533,7 +533,12 @@ public String getValue(ConfigOption<?> configOption) {
@Override
public RssConf clone() {
- RssConf config = new RssConf();
+ RssConf config;
+ try {
+ config = (RssConf) super.clone();
Review Comment:
This is not enough for copy `settings` field.
```java
private final ConcurrentHashMap<String, Object> settings;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
