kaijchen commented on code in PR #38:
URL: https://github.com/apache/incubator-uniffle/pull/38#discussion_r919612578
##########
common/src/main/java/org/apache/uniffle/common/config/RssConf.java:
##########
@@ -532,9 +532,9 @@ public String getValue(ConfigOption<?> configOption) {
//
--------------------------------------------------------------------------------------------
@Override
- public RssConf clone() {
- RssConf config = new RssConf();
- config.addAll(this);
+ public RssConf clone() throws CloneNotSupportedException {
+ RssConf config = (RssConf) super.clone();
Review Comment:
In fact, this is the Cloneable idiom. If a subclass extends this class and
doesn't override `clone()`, it will still be correct.
`Object.clone()` is implemented in native code, it will always return a
object in exact same class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
