frankliee commented on PR #38: URL: https://github.com/apache/incubator-uniffle/pull/38#issuecomment-1182894241
> > It is better to decouple '3. Fix bugs reported by spotbugs' in another PRs to make this PR more independent. > > If we only include 1 and 2, the CI will fail. If we only include 3, how do you know these bugs will be reported by spotbugs (and there is nothing more)? It is possible to make this checker won't break CI? If some changes are not what we really wanted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
