zuston commented on code in PR #53: URL: https://github.com/apache/incubator-uniffle/pull/53#discussion_r922819728
########## common/src/main/java/org/apache/uniffle/common/provider/HadoopAccessorProvider.java: ########## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.uniffle.common.provider; + +import static org.apache.uniffle.common.config.RssBaseConf.RSS_ACCESS_HADOOP_KERBEROS_ENABLE; +import static org.apache.uniffle.common.config.RssBaseConf.RSS_ACCESS_HADOOP_KERBEROS_KEYTAB_FILE; +import static org.apache.uniffle.common.config.RssBaseConf.RSS_ACCESS_HADOOP_KERBEROS_PRINCIPAL; +import static org.apache.uniffle.common.config.RssBaseConf.RSS_ACCESS_HADOOP_KERBEROS_RELOGIN_INTERVAL; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.util.concurrent.ThreadFactoryBuilder; +import java.io.Closeable; +import java.io.IOException; +import java.security.PrivilegedExceptionAction; +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; +import org.apache.commons.lang3.StringUtils; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.LocalFileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.uniffle.common.config.RssBaseConf; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * The HadoopAccessorProvider will provide the only entrypoint to get the hadoop filesystem whether + * the hadoop cluster is kerberized or not. + * <p> + * It should be initialized when the shuffle server/coordinator starts. And in client, there is no need + * to login with keytab at startup, the authentication of client side should be managed by computing framework + * like Spark/MR. + */ +public class HadoopAccessorProvider implements Closeable { + private static final Logger LOGGER = LoggerFactory.getLogger(HadoopAccessorProvider.class); + + private static volatile HadoopAccessorProvider provider; + + private Map<String, UserGroupInformation> cache = new ConcurrentHashMap<>(); + private ScheduledExecutorService scheduledExecutorService; + private boolean kerberosEnabled = false; + private RssBaseConf rssBaseConf; + private long reLoginIntervalSec; + + private HadoopAccessorProvider(RssBaseConf rssConf) throws Exception { Review Comment: But the coordinator also use this HadoopAccessorProvider. So maybe we should define the general hadoop prefix for coordinator and shuffle server. Right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
