zuston commented on code in PR #53:
URL: https://github.com/apache/incubator-uniffle/pull/53#discussion_r923349401
##########
common/src/main/java/org/apache/uniffle/common/RemoteStorageInfo.java:
##########
@@ -34,8 +34,10 @@ public class RemoteStorageInfo implements Serializable {
private final String path;
private final Map<String, String> confItems;
+ private String user;
Review Comment:
You are right. It looks the RemoteStorageInfo should only store storage
metadata instead of spark job info like user.
Maybe we should still add the param of `user` in the method of
`registerShuffle`. Do u think so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
