jerqi commented on code in PR #53:
URL: https://github.com/apache/incubator-uniffle/pull/53#discussion_r923354116


##########
common/src/main/java/org/apache/uniffle/common/RemoteStorageInfo.java:
##########
@@ -34,8 +34,10 @@ public class RemoteStorageInfo implements Serializable {
   private final String path;
   private final Map<String, String> confItems;
 
+  private String user;

Review Comment:
   > user shouldn't be member of RemoteStorageInfo which is used for describe 
storage only.
   
   User seems only to be used for storage, what's other usage for shuffle 
server?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to