jerqi commented on PR #74: URL: https://github.com/apache/incubator-uniffle/pull/74#issuecomment-1195658953
> > Did you verify this patch? I think we would better have ut for every pr, we should test the feature by hand at least. > > We have tested in production environment. Sometimes it is difficult to write ut, I will try to write ut for this pr later I know it's sometimes diffcult. If you can't write ut for it. you should provide some production envrionment detailed data to prove the effect of the pr. It's best to have screenshot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
